]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
smb: client: require net admin for CIFS SWN netlink
authorMichael Bommarito <michael.bommarito@gmail.com>
Mon, 18 May 2026 00:11:50 +0000 (20:11 -0400)
committerSteve French <stfrench@microsoft.com>
Thu, 21 May 2026 16:15:17 +0000 (11:15 -0500)
commitd1ebfce2c1d161186a82e77590bf7da2ea1bce91
tree88ead13c19d29b03988f296b511884c23e176511
parentfbc15231181669b51c0103fd74c9c2ac2756ab56
smb: client: require net admin for CIFS SWN netlink

CIFS_GENL_CMD_SWN_NOTIFY is the userspace witness-notify command.  The
intended sender is the cifs.witness helper, but the generic-netlink
operation currently has no capability flag, so any local process can send
RESOURCE_CHANGE or CLIENT_MOVE notifications to the in-kernel witness
handler.

The same family exposes CIFS_GENL_MCGRP_SWN without multicast-group
capability flags.  Register messages sent to that group include the witness
registration id and, for NTLM-authenticated mounts, the username, domain,
and password attributes copied from the CIFS session.  An unprivileged
local process should not be able to join that group and receive those
messages.

Require CAP_NET_ADMIN for incoming SWN_NOTIFY commands with
GENL_ADMIN_PERM, and require CAP_NET_ADMIN over the network namespace for
joining the SWN multicast group with GENL_MCAST_CAP_NET_ADMIN.  The
cifs.witness service runs with the privileges needed for both operations.

Fixes: fed979a7e082 ("cifs: Set witness notification handler for messages from userspace daemon")
Cc: stable@vger.kernel.org
Signed-off-by: Michael Bommarito <michael.bommarito@gmail.com>
Assisted-by: Claude:claude-opus-4-7
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/netlink.c