]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
e1000: check return value of e1000_read_eeprom
authorAgalakov Daniil <ade@amicon.ru>
Wed, 18 Mar 2026 12:05:05 +0000 (15:05 +0300)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 6 Apr 2026 21:13:38 +0000 (14:13 -0700)
commitd3baa34a470771399c1495bc04b1e26ac15d598e
tree04b809077bbb9352c15e7057440c847d0ebfc655
parentb1e067240379f950a0022208e0685f3465c211cb
e1000: check return value of e1000_read_eeprom

[Why]
e1000_set_eeprom() performs a read-modify-write operation when the write
range is not word-aligned. This requires reading the first and last words
of the range from the EEPROM to preserve the unmodified bytes.

However, the code does not check the return value of e1000_read_eeprom().
If the read fails, the operation continues using uninitialized data from
eeprom_buff. This results in corrupted data being written back to the
EEPROM for the boundary words.

Add the missing error checks and abort the operation if reading fails.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Co-developed-by: Iskhakov Daniil <dish@amicon.ru>
Signed-off-by: Iskhakov Daniil <dish@amicon.ru>
Signed-off-by: Agalakov Daniil <ade@amicon.ru>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/e1000/e1000_ethtool.c