]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/xe/gsc: Fix double-free of managed BO in error path
authorShuicheng Lin <shuicheng.lin@intel.com>
Mon, 11 May 2026 15:41:34 +0000 (15:41 +0000)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 18 May 2026 13:22:18 +0000 (09:22 -0400)
commitd3ded53fab90996e7d94a39049e11962dd066725
treeea7d774b8dbde556685308bd8bfd409a78417bd4
parent6eb0168d091404bee11d1f0712515d77b8d01579
drm/xe/gsc: Fix double-free of managed BO in error path

The error path in xe_gsc_init_post_hwconfig() explicitly frees a BO
allocated with xe_managed_bo_create_pin_map() via
xe_bo_unpin_map_no_vm(). Since the managed BO already has a devm
cleanup action registered, this causes a double-free when devm
unwinds during probe failure.

Remove the explicit free and let devm handle it, consistent with
all other xe_managed_bo_create_pin_map() callers.

Fixes: 2e5d47fe7839 ("drm/xe/uc: Use managed bo for HuC and GSC objects")
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Assisted-by: Claude:claude-opus-4.6
Link: https://patch.msgid.link/20260511154134.223696-1-shuicheng.lin@intel.com
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
(cherry picked from commit 71d61e3e299a17139e47f980a4d6f425b2c59bf7)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_gsc.c