]> git.ipfire.org Git - thirdparty/bind9.git/commit
Prevent "idna" test failures with libidn2 2.2.0+
authorMichał Kępień <michal@isc.org>
Wed, 26 Jun 2019 12:20:17 +0000 (14:20 +0200)
committerMichał Kępień <michal@isc.org>
Wed, 26 Jun 2019 12:41:10 +0000 (14:41 +0200)
commitd48ba3ce120f2f2b2a27344840155c4a6251eced
tree4c625a1805679c8a011ff25ebfb678f22a505922
parentd9164ab61c9823d06b2430b22f4648f0e3d61cb4
Prevent "idna" test failures with libidn2 2.2.0+

libidn2 2.2.0+ parses Punycode more strictly than older versions and
thus "dig +idnin +noidnout xn--19g" fails with libidn2 2.2.0+ but
succeeds with older versions.

We could preserve the old behavior by using the IDN2_NO_ALABEL_ROUNDTRIP
flag available in libidn2 2.2.0+, but:

  - this change in behavior is considered a libidn2 bug fix [1],
  - we want to make sure dig behaves as expected, not libidn2,
  - implementing that would require additional configure.ac cruft.

Removing the problematic check appears to be the simplest solution as it
does not prevent the relevant block of checks in the "idna" system test
from achieving its purpose, i.e. ensuring dig properly handles invalid
U-labels.

[1] see upstream commit 241e8f486134793cb0f4a5b0e5817a97883401f5

(cherry picked from commit 60ce0ed411305d5bae38ab78921e7b0255207ab0)
bin/tests/system/idna/tests.sh