]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
NFSv4: Fix a dentry leak on alias use
authorBenjamin Coddington <bcodding@redhat.com>
Wed, 17 Feb 2016 15:41:41 +0000 (10:41 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Mar 2016 23:06:53 +0000 (15:06 -0800)
commitd4db460720392ee6cb687db260417c85fd8c7fc4
tree14d1bd1b4b634b0a0b97d81db8507f79c72aeb2e
parentebbc1058f6efbd635e6c7c19cba5db1ad3acfcda
NFSv4: Fix a dentry leak on alias use

commit d9dfd8d741683347ee159d25f5b50c346a0df557 upstream.

In the case where d_add_unique() finds an appropriate alias to use it will
have already incremented the reference count.  An additional dget() to swap
the open context's dentry is unnecessary and will leak a reference.

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Fixes: 275bb307865a3 ("NFSv4: Move dentry instantiation into the NFSv4-...")
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/nfs4proc.c