]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't call CheckAttributeType() with InvalidOid on dropped cols
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Apr 2026 18:05:27 +0000 (21:05 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Apr 2026 18:31:45 +0000 (21:31 +0300)
commitd54e75441518da3207fa5a44f34d300956d3c2c2
tree1a3c4635330d5d0ccbf87074d1f00fcdc7fa3fde
parent54343f6f9046caa31c71a72479fd567322d72591
Don't call CheckAttributeType() with InvalidOid on dropped cols

If CheckAttributeType() is called with InvalidOid, it performs a bunch
of pointless, futile syscache lookups with InvalidOid, but ultimately
tolerates it and has no effect. We were calling it with InvalidOid on
dropped columns, but it seems accidental that it works, so let's stop
doing it.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/93ce56cd-02a6-4db1-8224-c8999372facc@iki.fi
Backpatch-through: 14
src/backend/catalog/heap.c