]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: mali-c55: Initialize the ISP in enable_streams()
authorJacopo Mondi <jacopo.mondi@ideasonboard.com>
Mon, 19 Jan 2026 11:20:56 +0000 (12:20 +0100)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 24 Mar 2026 15:13:09 +0000 (16:13 +0100)
commitd5c24b71da547fdb5bea51a69d62f9e2a609431d
tree7467856d512cd9ed06bc49d7954c04f2c238a3d7
parentdf16624248296ce4e8890c7ddcc95f0ccb642bcd
media: mali-c55: Initialize the ISP in enable_streams()

The Mali C55 driver initializes the ISP in two points:

1) At probe time it disables ISP blocks by configuring them in bypass
   mode
2) At enable_streams() it initializes the crop rectangles and the image
   processing pipeline using the current image format

However, as ISP blocks are configured by userspace, if their
configuration is not reset, from the second enable_streams() call
onwards the ISP configuration will depend on the previous streaming
session configuration.

To re-initialize the ISP completely at enable_streams() time consolidate
the ISP block bypass configuration and the image processing path
configuration in a single function to be called at enabled_streams()
time.

Cc: stable@vger.kernel.org
Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver")
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/arm/mali-c55/mali-c55-common.h
drivers/media/platform/arm/mali-c55/mali-c55-core.c
drivers/media/platform/arm/mali-c55/mali-c55-isp.c
drivers/media/platform/arm/mali-c55/mali-c55-params.c