]> git.ipfire.org Git - thirdparty/iptables.git/commit
iptables/libiptc perf issue: Sorting chain during pull-out
authorJesper Dangaard Brouer <hawk@comx.dk>
Wed, 28 Nov 2007 08:40:26 +0000 (08:40 +0000)
committerPatrick McHardy <kaber@trash.net>
Wed, 28 Nov 2007 08:40:26 +0000 (08:40 +0000)
commitd8cb787ab44e9d2de4fd3b04fcaa370c9918fc5d
treee4824f9e346db25ff0c1fc90a2c02fda7a454fd3
parente29da4e9610ab376593e50a44efba874a533dfe0
iptables/libiptc perf issue: Sorting chain during pull-out

Performance optimize scalability issue:
  Sorting chain during pull-out give worst-case runtime O(Chains2).

When pulling out the blob, every chain name is inserted alphabetically
into a linked list (by function iptc_insert_chain()).  The problem
with this approach is that the chain names delivered in the blob is
already sorted (as we push it back to the kernel sorted).

This cause chain parsing to always process every element in the chain
list and finish with a tail add.  Causing worst-case runtime O(C2/2)
for alphabetically sorting of chains.

The patch solves this by only calling iptc_insert_chain() when
creating new chains.

Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
libiptc/libiptc.c