]> git.ipfire.org Git - thirdparty/linux.git/commit
sched_ext: Temporarily work around pick_task_scx() being called without balance_scx()
authorTejun Heo <tj@kernel.org>
Fri, 6 Sep 2024 18:17:09 +0000 (08:17 -1000)
committerTejun Heo <tj@kernel.org>
Fri, 6 Sep 2024 18:17:09 +0000 (08:17 -1000)
commitda330f5e4c197980ce4d343b1e557c9f33282770
treec986a45b591159c12242cefbfa410405638e37d8
parent649e980dadee36f961738d054627225542d547a2
sched_ext: Temporarily work around pick_task_scx() being called without balance_scx()

pick_task_scx() must be preceded by balance_scx() but there currently is a
bug where fair could say yes on balance() but no on pick_task(), which then
ends up calling pick_task_scx() without preceding balance_scx(). Work around
by dropping WARN_ON_ONCE() and ignoring cases which don't make sense.

This isn't great and can theoretically lead to stalls. However, for
switch_all cases, this happens only while a BPF scheduler is being loaded or
unloaded, and, for partial cases, fair will likely keep triggering this CPU.

This will be reverted once the fair behavior is fixed.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
kernel/sched/ext.c