]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pds_core: fix debugfs_lookup dentry leak and error handling
authorNikhil P. Rao <nikhil.rao@amd.com>
Fri, 15 May 2026 21:29:07 +0000 (21:29 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 20 May 2026 02:18:33 +0000 (19:18 -0700)
commitdc416e32baaeb620b9809e9e25fc7b30889686e9
treea67f5770c2fb9bced9157799c817f37a469607f0
parent0e46b6635b03d29807f810c3b415c4755a3f958d
pds_core: fix debugfs_lookup dentry leak and error handling

debugfs_lookup() returns a dentry with an elevated reference count that
must be released with dput(). The current code discards the returned
dentry without calling dput(), causing a reference leak on every
firmware reset recovery.

Additionally, when CONFIG_DEBUG_FS is disabled, debugfs_lookup()
returns ERR_PTR(-ENODEV), not NULL. The current check passes for error
pointers and would call dput() on an invalid pointer, causing a crash.

Fixes: bc90fbe0c318 ("pds_core: Rework teardown/setup flow to be more common")
Signed-off-by: Nikhil P. Rao <nikhil.rao@amd.com>
Link: https://patch.msgid.link/20260515212907.998028-3-nikhil.rao@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/amd/pds_core/debugfs.c