]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ACPI / sysfs: fix error code in get_status()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 5 May 2016 13:23:04 +0000 (16:23 +0300)
committerJiri Slaby <jslaby@suse.cz>
Fri, 23 Sep 2016 07:29:23 +0000 (09:29 +0200)
commitdc7d223a5de64dc78396a98c2f034ba12dc160e1
tree1c8b398c45a7830511f8690beb20e0d868ea9b45
parent1186d77797e84479057ba69cae221e5e2b06bf04
ACPI / sysfs: fix error code in get_status()

commit f18ebc211e259d4f591e39e74b2aa2de226c9a1d upstream.

The problem with ornamental, do-nothing gotos is that they lead to
"forgot to set the error code" bugs.  We should be returning -EINVAL
here but we don't.  It leads to an uninitalized variable in
counter_show():

    drivers/acpi/sysfs.c:603 counter_show()
    error: uninitialized symbol 'status'.

Fixes: 1c8fce27e275 (ACPI: introduce drivers/acpi/sysfs.c)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/acpi/sysfs.c