]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: use skb_header_pointer() for TCPv4 GSO frag_off check
authorGuoyu Su <yss2813483011xxl@gmail.com>
Fri, 27 Mar 2026 15:35:07 +0000 (23:35 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 31 Mar 2026 00:35:21 +0000 (17:35 -0700)
commitddc748a391dd8642ba6b2e4fe22e7f2ddf84b7f0
tree6aa66f93e6b59b007518f09cb9d421409efc8281
parent514aac3599879a7ed48b7dc19e31145beb6958ac
net: use skb_header_pointer() for TCPv4 GSO frag_off check

Syzbot reported a KMSAN uninit-value warning in gso_features_check()
called from netif_skb_features() [1].

gso_features_check() reads iph->frag_off to decide whether to clear
mangleid_features. Accessing the IPv4 header via ip_hdr()/inner_ip_hdr()
can rely on skb header offsets that are not always safe for direct
dereference on packets injected from PF_PACKET paths.

Use skb_header_pointer() for the TCPv4 frag_off check so the header read
is robust whether data is already linear or needs copying.

[1] https://syzkaller.appspot.com/bug?extid=1543a7d954d9c6d00407

Link: https://lore.kernel.org/netdev/willemdebruijn.kernel.1a9f35039caab@gmail.com/
Fixes: cbc53e08a793 ("GSO: Add GSO type for fixed IPv4 ID")
Reported-by: syzbot+1543a7d954d9c6d00407@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=1543a7d954d9c6d00407
Tested-by: syzbot+1543a7d954d9c6d00407@syzkaller.appspotmail.com
Signed-off-by: Guoyu Su <yss2813483011xxl@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20260327153507.39742-1-yss2813483011xxl@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/dev.c