]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mwifiex: printk() overflow with 32-byte SSIDs
authorBrian Norris <briannorris@chromium.org>
Wed, 9 Nov 2016 02:28:24 +0000 (18:28 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 23 Feb 2017 03:54:36 +0000 (03:54 +0000)
commitdddd478f8d027aa801cd14e32a40c5673419249f
tree5ebbe66b80105df8cd48e60c30770405c75f2f30
parent52e8b41f2df336dd2f78e80dea53ead5b9d2824b
mwifiex: printk() overflow with 32-byte SSIDs

commit fcd2042e8d36cf644bd2d69c26378d17158b17df upstream.

SSIDs aren't guaranteed to be 0-terminated. Let's cap the max length
when we print them out.

This can be easily noticed by connecting to a network with a 32-octet
SSID:

[ 3903.502925] mwifiex_pcie 0000:01:00.0: info: trying to associate to
'0123456789abcdef0123456789abcdef <uninitialized mem>' bssid
xx:xx:xx:xx:xx:xx

Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
Signed-off-by: Brian Norris <briannorris@chromium.org>
Acked-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
[bwh: Backported to 3.16: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/mwifiex/cfg80211.c