]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
USB: serial: kobil_sct: clean up tiocmset()
authorJohan Hovold <johan@kernel.org>
Wed, 22 Oct 2025 15:26:36 +0000 (17:26 +0200)
committerJohan Hovold <johan@kernel.org>
Mon, 27 Oct 2025 08:22:03 +0000 (09:22 +0100)
commitddf81605809652228469275f8598cf7d55450bdc
treeec39fcb21d12444533cc0aa54f97a7257aeae2ca
parent66b1c554a83dbe30db382c527890fead49e777f5
USB: serial: kobil_sct: clean up tiocmset()

Clean up the tiocmset() implementation by simplifying the flag check,
dropping some dev_dbg(), logging errors using dev_err() and using a
common control message call for both DTR and RTS to make the existing
logic easier to follow.

Note that the modem control lines are currently only manipulated in this
function, which therefore does not require any locking.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/kobil_sct.c