]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix incorrect comment for get_agg_clause_costs
authorDavid Rowley <drowley@postgresql.org>
Mon, 26 Jul 2021 02:56:09 +0000 (14:56 +1200)
committerDavid Rowley <drowley@postgresql.org>
Mon, 26 Jul 2021 02:56:09 +0000 (14:56 +1200)
commitdece64a941457686184654968ac1ded58b7d4ee8
tree71f1f2637f648b28e3c723eb5b8049914644f949
parentb0d28671964d61416248789e3cee4508ac6281b4
Fix incorrect comment for get_agg_clause_costs

Adjust the header comment in get_agg_clause_costs so that it matches what
the function currently does.  No recursive searching has been done ever
since 0a2bc5d61.  It also does not determine the aggtranstype like the
comment claimed. That's all done in preprocess_aggref().
preprocess_aggref also now determines the numOrderedAggs, so remove the
mention that get_agg_clause_costs also calculates "counts".

Normally, since this is just an adjustment of a comment it might not be
worth back-patching, but since this code is new to PG14 and that version
is still in beta, then it seems worth having the comments match.

Discussion: https://postgr.es/m/CAApHDvrrGrTJFPELrjx0CnDtz9B7Jy2XYW3Z2BKifAWLSaJYwQ@mail.gmail.com
Backpatch-though: 14
src/backend/optimizer/prep/prepagg.c