]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't call CheckAttributeType() with InvalidOid on dropped cols
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Apr 2026 18:05:27 +0000 (21:05 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Apr 2026 18:33:25 +0000 (21:33 +0300)
commite1830ebf52190ad48649c69ebd2a02fc5ba89366
tree7a852f844f2445acf42fe0aa7049b377cfca6822
parent34ebeb15c8b18330d992bc672c1192b0d9436fc7
Don't call CheckAttributeType() with InvalidOid on dropped cols

If CheckAttributeType() is called with InvalidOid, it performs a bunch
of pointless, futile syscache lookups with InvalidOid, but ultimately
tolerates it and has no effect. We were calling it with InvalidOid on
dropped columns, but it seems accidental that it works, so let's stop
doing it.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/93ce56cd-02a6-4db1-8224-c8999372facc@iki.fi
Backpatch-through: 14
src/backend/catalog/heap.c