]> git.ipfire.org Git - thirdparty/bind9.git/commit
refactor, add missing EDNS options, and fix option names
authorEvan Hunt <each@isc.org>
Thu, 24 Oct 2024 23:55:31 +0000 (16:55 -0700)
committerEvan Hunt <each@isc.org>
Tue, 29 Oct 2024 20:05:27 +0000 (20:05 +0000)
commite2393ba27bd334fb2146e1540c0dafcc75e9d688
treeed732bf78812fe1f0436442597347a5d822c1bf3
parentc30754f28b82cec4467c05452aae62ab56198830
refactor, add missing EDNS options, and fix option names

some EDNS option names, including DAU, DHU, N3U, and CHAIN,
were not printed in dns_message_pseudosectiontotext() or
_psuedosectiontoyaml(); they were displayed as unknown options.
this has been corrected.

that code was also refactored to use switch instead of if/else,
and to look up the option code names in a table to prevent
inconsistencies between the two formats. one such inconsistency
was corrected: the "TCP-KEEPALIVE" option is now always printed
with a hyphen, instead of being "TCP KEEPALIVE" when not using
YAML. the keepalive system test has been updated to expect this.

EDNS options that print DNS names (i.e., CHAIN and Report-Channel)
now enclose them in quotation marks to ensure YAML correctness.
the auth system test has been updated to expect this when grepping
for Report-Channel options.
bin/tests/system/auth/tests.sh
bin/tests/system/keepalive/tests.sh
lib/dns/include/dns/message.h
lib/dns/message.c