]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
s5p-mfc: Add release callback for memory region devs
authorJavier Martinez Canillas <javier@osg.samsung.com>
Tue, 3 May 2016 20:27:17 +0000 (16:27 -0400)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 22 Aug 2016 16:22:57 +0000 (12:22 -0400)
commite2591cbcf49e13ef2be20e38064c60730fc5b3aa
treeca471cd0d9fc9a0d605b02c5c847b1bd4c780994
parent7cc9ce02e9f06082152f619a33e3bdbf76e35a24
s5p-mfc: Add release callback for memory region devs

[ Upstream commit 6311f1261f59ce5e51fbe5cc3b5e7737197316ac ]

When s5p_mfc_remove() calls put_device() for the reserved memory region
devs, the driver core warns that the dev doesn't have a release callback:

WARNING: CPU: 0 PID: 591 at drivers/base/core.c:251 device_release+0x8c/0x90
Device 's5p-mfc-l' does not have a release() function, it is broken and must be fixed.

Also, the declared DMA memory using dma_declare_coherent_memory() isn't
relased so add a dev .release that calls dma_release_declared_memory().

Cc: <stable@vger.kernel.org>
Fixes: 6e83e6e25eb4 ("[media] s5p-mfc: Fix kernel warning on memory init")
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
drivers/media/platform/s5p-mfc/s5p_mfc.c