]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
xfs: don't swallow dquot recovery verification errors
authorLong Li <leo.lilong@huawei.com>
Mon, 27 Jul 2026 02:38:49 +0000 (10:38 +0800)
committerCarlos Maiolino <cem@kernel.org>
Mon, 3 Aug 2026 08:21:33 +0000 (10:21 +0200)
commite2b4a856085e9bd939bde2dee0d08b1d41babde9
treef9305abbb8084cfe4edb9998850cfb3185de4e94
parent63320a0f70f66f311f4bccff3af0719c2119f46c
xfs: don't swallow dquot recovery verification errors

xlog_recover_dquot_commit_pass2() validates the recovered dquot with
xfs_dqblk_verify() and, on failure, sets error = -EFSCORRUPTED and jumps
to out_release.  But out_release unconditionally returns 0, so the
corruption error is discarded: the caller xlog_recover_items_pass2()
sees success, log recovery proceeds as if the dquot were valid, and the
corrupt quota buffer can be written back to disk.

Fixes: 9c235dfc3d3f ("xfs: dquot recovery does not validate the recovered dquot")
Cc: stable@vger.kernel.org # v6.8
Signed-off-by: Long Li <leo.lilong@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_dquot_item_recover.c