]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
netfs: Fix NULL pointer dereference in netfs_unbuffered_write() on retry
authorDeepanshu Kartikey <kartikey406@gmail.com>
Sat, 7 Mar 2026 04:39:47 +0000 (10:09 +0530)
committerChristian Brauner <brauner@kernel.org>
Mon, 9 Mar 2026 09:21:56 +0000 (10:21 +0100)
commite9075e420a1eb3b52c60f3b95893a55e77419ce8
treeae0861e4d1aa617f30e946639c028750cbf7d6d1
parent67e467a11f62ff64ad219dc6aa5459e132c79d14
netfs: Fix NULL pointer dereference in netfs_unbuffered_write() on retry

When a write subrequest is marked NETFS_SREQ_NEED_RETRY, the retry path
in netfs_unbuffered_write() unconditionally calls stream->prepare_write()
without checking if it is NULL.

Filesystems such as 9P do not set the prepare_write operation, so
stream->prepare_write remains NULL. When get_user_pages() fails with
-EFAULT and the subrequest is flagged for retry, this results in a NULL
pointer dereference at fs/netfs/direct_write.c:189.

Fix this by mirroring the pattern already used in write_retry.c: if
stream->prepare_write is NULL, skip renegotiation and directly reissue
the subrequest via netfs_reissue_write(), which handles iterator reset,
IN_PROGRESS flag, stats update and reissue internally.

Fixes: a0b4c7a49137 ("netfs: Fix unbuffered/DIO writes to dispatch subrequests in strict sequence")
Reported-by: syzbot+7227db0fbac9f348dba0@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=7227db0fbac9f348dba0
Signed-off-by: Deepanshu Kartikey <Kartikey406@gmail.com>
Link: https://patch.msgid.link/20260307043947.347092-1-kartikey406@gmail.com
Tested-by: syzbot+7227db0fbac9f348dba0@syzkaller.appspotmail.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/netfs/direct_write.c