]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pmdomain: bcm: bcm2835-power: Increase ASB control timeout
authorMaíra Canal <mcanal@igalia.com>
Tue, 17 Mar 2026 22:41:49 +0000 (19:41 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Mar 2026 10:08:48 +0000 (11:08 +0100)
commitea4fa54b83bb2e4a21e9026824bfe271b1a6ee1e
tree96925bfc91fd13b7a0bc7a0f4331a6b12930a620
parent45fd9d8352f22fee923b3c65b1a21b7e587fdd05
pmdomain: bcm: bcm2835-power: Increase ASB control timeout

commit b826d2c0b0ecb844c84431ba6b502e744f5d919a upstream.

The bcm2835_asb_control() function uses a tight polling loop to wait
for the ASB bridge to acknowledge a request. During intensive workloads,
this handshake intermittently fails for V3D's master ASB on BCM2711,
resulting in "Failed to disable ASB master for v3d" errors during
runtime PM suspend. As a consequence, the failed power-off leaves V3D in
a broken state, leading to bus faults or system hangs on later accesses.

As the timeout is insufficient in some scenarios, increase the polling
timeout from 1us to 5us, which is still negligible in the context of a
power domain transition. Also, replace the open-coded ktime_get_ns()/
cpu_relax() polling loop with readl_poll_timeout_atomic().

Cc: stable@vger.kernel.org
Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.")
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pmdomain/bcm/bcm2835-power.c