]> git.ipfire.org Git - thirdparty/squid.git/commit
Bug 4238: assertion Read.cc:205: "params.data == data"
authorChristos Tsantilas <chtsanti@users.sourceforge.net>
Mon, 11 May 2015 15:50:30 +0000 (08:50 -0700)
committerAmos Jeffries <squid3@treenet.co.nz>
Mon, 11 May 2015 15:50:30 +0000 (08:50 -0700)
commitea56962faed8bd1b0a04418c4bc96becae327a19
treeea23479f64437ee8b729fa5e31aefc48764720e7
parent9a5c5714ecd7ee949a2499bc893dc9e69f848232
Bug 4238: assertion Read.cc:205: "params.data == data"

Inside IdleConnList::findUseable the IdleConnList::removeAt call can delete
"this" IdleConnList object. The IdleConnList::clearHandlers called imediatelly
after the removeAt method, will try to use the invalid "this" object in
a comm_read_cancel function call, causing this assertion or other similar.

This patch fixes the IdleConnList::findUseable, IdleConnList::pop and
IdleConnList::findAndClose methods to call IdleConnList::clearHandlers before
the IdleConnList::removeAt is called.

This is a Measurement Factory project
src/pconn.cc