]> git.ipfire.org Git - thirdparty/git.git/commit
completion: fix zsh alias listing for subsection aliases
authorJonatan Holmgren <jonatan@jontes.page>
Wed, 18 Feb 2026 21:57:37 +0000 (22:57 +0100)
committerJunio C Hamano <gitster@pobox.com>
Thu, 19 Feb 2026 18:13:20 +0000 (10:13 -0800)
commitedd8ad18a643d47dd92b08ab865bf7f4a26f50bc
tree6fb3071f7b6d8c7563b03fa8200159764f1e0f36
parentac1f12a9de4b79b176a08f524fecdb092ff00e74
completion: fix zsh alias listing for subsection aliases

The zsh completion function __git_zsh_cmd_alias() uses 'git config
--get-regexp' to enumerate aliases and then strips the "alias." prefix
from each key. For subsection-style aliases (alias.name.command), this
leaves "name.command" as the completion candidate instead of just
"name".

The bash completion does not have this problem because it goes through
'git --list-cmds=alias', which calls list_aliases() in C and already
handles both alias syntaxes correctly. However, zsh needs both the
alias name and its value for descriptive completion, which
--list-cmds=alias does not provide.

Add a hidden --aliases-for-completion option to 'git help', following
the existing --config-for-completion pattern. It outputs NUL-separated
"name\nvalue" pairs using list_aliases(), which correctly resolves both
the traditional (alias.name) and subsection (alias.name.command)
formats. Update __git_zsh_cmd_alias() to use it.

Signed-off-by: Jonatan Holmgren <jonatan@jontes.page>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/help.c
contrib/completion/git-completion.zsh