]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
netfilter: nfnetlink_queue: fix entry leak in bridge verdict error path
authorHyunwoo Kim <imv4bel@gmail.com>
Sat, 7 Mar 2026 17:24:06 +0000 (02:24 +0900)
committerFlorian Westphal <fw@strlen.de>
Tue, 10 Mar 2026 13:10:42 +0000 (14:10 +0100)
commitf1ba83755d81c6fc66ac7acd723d238f974091e9
tree002ea99ecd2257cee892d699202da0ddb9b0ac3e
parentcfe770220ac2dbd3e104c6b45094037455da81d4
netfilter: nfnetlink_queue: fix entry leak in bridge verdict error path

nfqnl_recv_verdict() calls find_dequeue_entry() to remove the queue
entry from the queue data structures, taking ownership of the entry.
For PF_BRIDGE packets, it then calls nfqa_parse_bridge() to parse VLAN
attributes.  If nfqa_parse_bridge() returns an error (e.g. NFQA_VLAN
present but NFQA_VLAN_TCI missing), the function returns immediately
without freeing the dequeued entry or its sk_buff.

This leaks the nf_queue_entry, its associated sk_buff, and all held
references (net_device refcounts, struct net refcount).  Repeated
triggering exhausts kernel memory.

Fix this by dropping the entry via nfqnl_reinject() with NF_DROP verdict
on the error path, consistent with other error handling in this file.

Fixes: 8d45ff22f1b4 ("netfilter: bridge: nf queue verdict to use NFQA_VLAN and NFQA_L2HDR")
Reviewed-by: David Dull <monderasdor@gmail.com>
Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
net/netfilter/nfnetlink_queue.c