]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nfsd: fix auth_domain reference leak on nlm operations
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 25 Mar 2011 02:51:14 +0000 (22:51 -0400)
committerWilly Tarreau <w@1wt.eu>
Sat, 30 Apr 2011 14:53:34 +0000 (16:53 +0200)
commitf25d8e502520fcc99f9eb442d76391365dea7ecf
tree21e9c4adbfcf1fcf98263009985b8c73a5be7a1f
parent4481102ac28aa5759acb5aad56aa8c36c4afb198
nfsd: fix auth_domain reference leak on nlm operations

commit 954032d2527f2fce7355ba70709b5e143d6b686f upstream.

This was noticed by users who performed more than 2^32 lock operations
and hence made this counter overflow (eventually leading to
use-after-free's).  Setting rq_client to NULL here means that it won't
later get auth_domain_put() when it should be.

Appears to have been introduced in 2.5.42 by "[PATCH] kNFSd: Move auth
domain lookup into svcauth" which moved most of the rq_client handling
to common svcauth code, but left behind this one line.

Cc: Neil Brown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/nfsd/lockd.c