]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
packet: unconditionally free po->rollover
authorWillem de Bruijn <willemb@google.com>
Fri, 31 May 2019 16:37:23 +0000 (12:37 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jun 2019 10:19:11 +0000 (12:19 +0200)
commitf2bba1f6379f4c0fe6a203b56b700f587d02be66
tree01119e28ff587956f2854db9d8ce9d4ffffc2812
parentbab4057c77a4195f11af2c59f4f68d426fe31722
packet: unconditionally free po->rollover

[ Upstream commit afa0925c6fcc6a8f610e996ca09bc3215048033c ]

Rollover used to use a complex RCU mechanism for assignment, which had
a race condition. The below patch fixed the bug and greatly simplified
the logic.

The feature depends on fanout, but the state is private to the socket.
Fanout_release returns f only when the last member leaves and the
fanout struct is to be freed.

Destroy rollover unconditionally, regardless of fanout state.

Fixes: 57f015f5eccf2 ("packet: fix crash in fanout_demux_rollover()")
Reported-by: syzbot <syzkaller@googlegroups.com>
Diagnosed-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/packet/af_packet.c