]> git.ipfire.org Git - thirdparty/linux.git/commit
Bluetooth: ISO: Fix a use-after-free of the hci_conn pointer
authorLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Mon, 1 Jun 2026 18:52:09 +0000 (14:52 -0400)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Wed, 3 Jun 2026 15:23:09 +0000 (11:23 -0400)
commitf50331f2a1441ec49988832c3a95f2edacc47322
tree7426afd1acd32b6a01e87755270c82954d893793
parent5cbf290b79351971f20c7a533247e8d58a3f970c
Bluetooth: ISO: Fix a use-after-free of the hci_conn pointer

In iso_sock_rebind_bc(), the bis pointer is cached, then the socket lock is
dropped:
bis = iso_pi(sk)->conn->hcon;
/* Release the socket before lookups since that requires hci_dev_lock
 * which shall not be acquired while holding sock_lock for proper
 * ordering.
 */
release_sock(sk);
hci_dev_lock(bis->hdev);

During the unlocked window, could a concurrent close() destroy the connection
and free the bis structure, causing hci_dev_lock(bis->hdev) to access memory
after it is freed, fix this by using the hdev reference which was safely
acquired via iso_conn_get_hdev().

Fixes: d3413703d5f8 ("Bluetooth: ISO: Add support to bind to trigger PAST")
Reported-by: Sashiko <sashiko-bot@kernel.org>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/iso.c