]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pgcrypto: Fix check for buffer size
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Tue, 30 Jan 2024 10:15:46 +0000 (11:15 +0100)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Tue, 30 Jan 2024 10:15:46 +0000 (11:15 +0100)
commitf74b5c5bc67c3c1df799e5dd073a441984953b44
treee99534d92dd1e5650e09dbcb34d029d768a2abe1
parent6fc8a7b2b03bfcb26e2e7440251b6f17e01210c8
pgcrypto: Fix check for buffer size

The code copying the PGP block into the temp buffer failed to
account for the extra 2 bytes in the buffer which are needed
for the prefix. If the block was oversized, subsequent checks
of the prefix would have exceeded the buffer size.  Since the
block sizes are hardcoded in the list of supported ciphers it
can be verified that there is no live bug here. Backpatch all
the way for consistency though, as this bug is old.

Author: Mikhail Gribkov <youzhick@gmail.com>
Discussion: https://postgr.es/m/CAMEv5_uWvcMCMdRFDsJLz2Q8g16HEa9xWyfrkr+FYMMFJhawOw@mail.gmail.com
Backpatch-through: v12
contrib/pgcrypto/pgp-decrypt.c