]> git.ipfire.org Git - thirdparty/bind9.git/commit
Temporarily remove TCP fallback after UDP timeouts
authorOndřej Surý <ondrej@isc.org>
Thu, 14 May 2026 08:04:20 +0000 (10:04 +0200)
committerOndřej Surý (GitLab job 7417718) <ondrej@isc.org>
Tue, 19 May 2026 09:19:37 +0000 (09:19 +0000)
commitf82c6f0cba4456459c6d822b57740d71d7fc478f
treea59dd739cca8628b43c3d941742782e02b08eb97
parent0fe9e2c92301929d90a1349c8fe05b945c78bee0
Temporarily remove TCP fallback after UDP timeouts

The retry path in resquery_send() that flipped DNS_FETCHOPT_TCP on a
query whose dispatch had already been bound as UDP in fctx_query() had
no effect on the transport actually used, but did leave a stale TCP
bit visible to downstream consumers (dnstap framing, cookie checks,
the AUTHORITY-NS spoofability guard).

The ineffective code has been removed from resquery_send().  The
TCP fallback functionality will be corrected and restored in the next
commit.

Assisted-by: Claude:claude-opus-4-7
(cherry picked from commit 01523a078a848873be90572171124cdd5c1c7b0c)
bin/tests/system/dispatch/ans4/ans.py [new file with mode: 0644]
bin/tests/system/dispatch/ans4/tcp-only.db [new file with mode: 0644]
bin/tests/system/dispatch/ns1/root.db
bin/tests/system/dispatch/tests_tcponly.py [new file with mode: 0644]
lib/dns/resolver.c