]> git.ipfire.org Git - thirdparty/linux.git/commit
net: skbuff: preserve shared-frag marker during coalescing
authorWilliam Bowling <vakzz@zellic.io>
Wed, 13 May 2026 04:16:35 +0000 (04:16 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 15 May 2026 00:22:00 +0000 (17:22 -0700)
commitf84eca5817390257cef78013d0112481c503b4a3
tree25e8fb467b9ad13fc004ea1c8b188ecd5279d1d7
parent7d260c5d2d89eb2c8c528d54b576b3aae3e20231
net: skbuff: preserve shared-frag marker during coalescing

skb_try_coalesce() can attach paged frags from @from to @to.  If @from
has SKBFL_SHARED_FRAG set, the resulting @to skb can contain the same
externally-owned or page-cache-backed frags, but the shared-frag marker
is currently lost.

That breaks the invariant relied on by later in-place writers.  In
particular, ESP input checks skb_has_shared_frag() before deciding
whether an uncloned nonlinear skb can skip skb_cow_data().  If TCP
receive coalescing has moved shared frags into an unmarked skb, ESP can
see skb_has_shared_frag() as false and decrypt in place over page-cache
backed frags.

Propagate SKBFL_SHARED_FRAG when skb_try_coalesce() transfers paged
frags.  The tailroom copy path does not need the marker because it copies
bytes into @to's linear data rather than transferring frag descriptors.

Fixes: cef401de7be8 ("net: fix possible wrong checksum generation")
Fixes: f4c50a4034e6 ("xfrm: esp: avoid in-place decrypt on shared skb frags")
Signed-off-by: William Bowling <vakzz@zellic.io>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Tested-by: Jiayuan Chen <jiayuan.chen@linux.dev>
Link: https://patch.msgid.link/20260513041635.1289541-1-vakzz@zellic.io
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/skbuff.c