]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
spi: atcspi200: Handle invalid buswidth and fix compiler warning
authorCL Wang <cl634@andestech.com>
Tue, 3 Mar 2026 02:47:37 +0000 (10:47 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 11 Mar 2026 19:08:43 +0000 (19:08 +0000)
commitf879365c5bb210ed0d0b0aae1a0202d0c0b4b9d0
treeec0250a441ce37bd864a0b4e909b462585b4312f
parent743956bb9990214ff1dac66ef59e27221dc3c2d8
spi: atcspi200: Handle invalid buswidth and fix compiler warning

The kernel test robot reported a compile-time error regarding the
FIELD_PREP() value being too large for the TRANS_DUAL_QUAD field:

  error: FIELD_PREP: value too large for the field
  note: in expansion of macro 'TRANS_DUAL_QUAD'
  tc |= TRANS_DUAL_QUAD(ffs(op->data.buswidth) - 1);

This occurs because TRANS_DUAL_QUAD is defined as a 2-bit field, and
GCC's static analysis cannot deduce that `ffs(op->data.buswidth) - 1`
will strictly fall within the 0~3 range. Although the SPI framework
guarantees that `op->data.buswidth` is valid at runtime (e.g., 1, 2,
4, 8), an explicit bounds check is necessary to satisfy the compiler.

To resolve the build warning, introduce a safe fallback mechanism.
If an unexpected buswidth is encountered, the driver will trigger
a WARN_ON_ONCE to leave a trace and fall back to width_code = 0
(standard 1-bit SPI mode). This approach guarantees predictable
hardware behavior.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202602140738.P7ZozxzI-lkp@intel.com/
Suggested-by: Pei Xiao <xiaopei01@kylinos.cn>
Signed-off-by: CL Wang <cl634@andestech.com>
Link: https://patch.msgid.link/20260303024737.1791196-1-cl634@andestech.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-atcspi200.c