]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Fri, 3 Sep 2021 07:35:43 +0000 (15:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:26:45 +0000 (12:26 +0200)
commitf9b308f7302efbb3de087c087ad0d18eda071d92
tree5734ede63493b39980e5f39b5419bd2d8d175f28
parent93f54354ccc8cffd4daea2837f7b95b6da0966a9
qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom

[ Upstream commit 9ddbc2a00d7f63fa9748f4278643193dac985f2d ]

Previous commit 68233c583ab4 removes the qlcnic_rom_lock()
in qlcnic_pinit_from_rom(), but remains its corresponding
unlock function, which is odd. I'm not very sure whether the
lock is missing, or the unlock is redundant. This bug is
suggested by a static analysis tool, please advise.

Fixes: 68233c583ab4 ("qlcnic: updated reset sequence")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c