]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
iio: adc: mt6359: fix unchecked return value in mt6358_read_imp
authorSalah Triki <salah.triki@gmail.com>
Mon, 27 Apr 2026 20:12:38 +0000 (21:12 +0100)
committerJonathan Cameron <jic23@kernel.org>
Fri, 15 May 2026 11:04:11 +0000 (12:04 +0100)
commitf9bbd943c34a9ad60e593a4b99ce2394e4e2381b
tree452456ec4a47d715f5e7b8df872c292c3083e955
parent5ace794c3ded38038a1f97f9ea26b9a8c835c111
iio: adc: mt6359: fix unchecked return value in mt6358_read_imp

In mt6358_read_imp(), the variable val_v is passed to regmap_read()
but the return value is not checked. If the read fails, val_v remains
uninitialized and its random stack content is subsequently reported
as a measurement result.

Initialize val_v to zero to ensure a predictable value is reported
in case of bus failure and to prevent potential stack data leakage.
This also satisfies static analyzers that might otherwise flag the
variable as used uninitialized.

Fixes: 3587914bf61d ("iio: adc: Add support for MediaTek MT6357/8/9 Auxiliary ADC")
Signed-off-by: Salah Triki <salah.triki@gmail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/adc/mt6359-auxadc.c