]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
smb: client: fix sbflags initialization
authorArnd Bergmann <arnd@arndb.de>
Fri, 6 Mar 2026 15:07:13 +0000 (16:07 +0100)
committerSteve French <stfrench@microsoft.com>
Tue, 10 Mar 2026 22:22:03 +0000 (17:22 -0500)
commitfae11330dc0642065568d6c0045322293fe59bc6
treec9d14021b1a5d6bbe07b252b3a0ce06b08b93f23
parent4a7d2729dc99437dbb880a64c47828c0d191b308
smb: client: fix sbflags initialization

The newly introduced variable is initialized in an #ifdef block
but used outside of it, leading to undefined behavior when
CONFIG_CIFS_ALLOW_INSECURE_LEGACY is disabled:

fs/smb/client/dir.c:417:9: error: variable 'sbflags' is uninitialized when used here [-Werror,-Wuninitialized]
  417 |                                 if (sbflags & CIFS_MOUNT_DYNPERM)
      |                                     ^~~~~~~

Move the initialization into the declaration, the same way as the
other similar function do it.

Fixes: 4fc3a433c139 ("smb: client: use atomic_t for mnt_cifs_flags")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/dir.c