]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: endpoint: Fix configfs group removal on driver teardown
authorDamien Le Moal <dlemoal@kernel.org>
Tue, 24 Jun 2025 11:45:44 +0000 (20:45 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:24:29 +0000 (16:24 +0200)
commitfb454ba99189280e205f2b141dc5daef60b18484
treef3b99bdc3d9dc5282d978c12b546d7bc35eb6fed
parentdc4ffbd571716ff3b171418fb03abe80e720a7b1
PCI: endpoint: Fix configfs group removal on driver teardown

commit 910bdb8197f9322790c738bb32feaa11dba26909 upstream.

An endpoint driver configfs attributes group is added to the
epf_group list of struct pci_epf_driver by pci_epf_add_cfs() but an
added group is not removed from this list when the attribute group is
unregistered with pci_ep_cfs_remove_epf_group().

Add the missing list_del() call in pci_ep_cfs_remove_epf_group()
to correctly remove the attribute group from the driver list.

With this change, once the loop over all attribute groups in
pci_epf_remove_cfs() completes, the driver epf_group list should be
empty. Add a WARN_ON() to make sure of that.

Fixes: ef1433f717a2 ("PCI: endpoint: Create configfs entry for each pci_epf_device_id table entry")
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250624114544.342159-3-dlemoal@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pci/endpoint/pci-ep-cfs.c
drivers/pci/endpoint/pci-epf-core.c