]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
eth: sungem: remove .ndo_poll_controller to avoid deadlocks
authorJakub Kicinski <kuba@kernel.org>
Wed, 8 May 2024 13:45:04 +0000 (06:45 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:39:25 +0000 (13:39 +0200)
commitfbeeb55dbb33d562149c57e794f06b7414e44289
treeb1bcb7d5d2786beeb51cc20ebbb1e4bf7b54d642
parentfb724a948d23589e1624876cd02f7d65c7b2911b
eth: sungem: remove .ndo_poll_controller to avoid deadlocks

[ Upstream commit ac0a230f719b02432d8c7eba7615ebd691da86f4 ]

Erhard reports netpoll warnings from sungem:

  netpoll_send_skb_on_dev(): eth0 enabled interrupts in poll (gem_start_xmit+0x0/0x398)
  WARNING: CPU: 1 PID: 1 at net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c

gem_poll_controller() disables interrupts, which may sleep.
We can't sleep in netpoll, it has interrupts disabled completely.
Strangely, gem_poll_controller() doesn't even poll the completions,
and instead acts as if an interrupt has fired so it just schedules
NAPI and exits. None of this has been necessary for years, since
netpoll invokes NAPI directly.

Fixes: fe09bb619096 ("sungem: Spring cleaning and GRO support")
Reported-and-tested-by: Erhard Furtner <erhard_f@mailbox.org>
Link: https://lore.kernel.org/all/20240428125306.2c3080ef@legion
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20240508134504.3560956-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/sun/sungem.c