]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ethernet: ti: cpsw: fix device and of_node leaks
authorJohan Hovold <johan@kernel.org>
Thu, 3 Nov 2016 17:40:20 +0000 (18:40 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 23 Feb 2017 03:54:30 +0000 (03:54 +0000)
commitfc4167f5277301dfc95bf43eed43b1b020f529f0
tree43058ab431f70ee0c3023d1bb4707150f6f44edf
parentcd9e47dc4a69d2dc7f1f7e7be3f40991b2a89ae2
net: ethernet: ti: cpsw: fix device and of_node leaks

commit c7262aaace1b17a650598063e3b9ee1785fde377 upstream.

Make sure to drop the references taken by of_get_child_by_name() and
bus_find_device() before returning from cpsw_phy_sel().

Note that holding a reference to the cpsw-phy-sel device does not
prevent the devres-managed private data from going away.

Fixes: 5892cd135e16 ("drivers: net: cpsw-phy-sel: Add new driver...")
Cc: Mugunthan V N <mugunthanvnm@ti.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/ethernet/ti/cpsw-phy-sel.c