]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
batman-adv: tt: fix negative last_changeset_len
authorSven Eckelmann <sven@narfation.org>
Sat, 2 May 2026 17:53:21 +0000 (19:53 +0200)
committerSven Eckelmann <sven@narfation.org>
Tue, 12 May 2026 06:33:52 +0000 (08:33 +0200)
commitfc92cdfcb295cefa4344d71a527d61b638b7bfc4
tree24baae42d5779d2a0a7817dfe220051447b1dbb7
parentb64963a2ceeb7529310b6cf253a1e540784422f4
batman-adv: tt: fix negative last_changeset_len

batadv_piv_tt::last_changeset_len len was declared as s16, but the field is
never intended to hold a negative value. When a value greater than 32767 is
assigned, it wraps to a negative signed integer.

In batadv_send_my_tt_response(), last_changeset_len is temporarily widened
to s32. The incorrectly negative s16 value propagates into the s32, causing
batadv_tt_prepare_tvlv_local_data() to allocate a full sized buffer but
populates only a small portion of it with the collected changeset. All
remaining bits are kept uninitialized.

Using an u16 avoids this type confusion and ensures that no (negative) sign
extension is performed in batadv_send_my_tt_response().

Cc: stable@kernel.org
Fixes: a73105b8d4c7 ("batman-adv: improved client announcement mechanism")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
net/batman-adv/types.h