]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: hda: cs35l41: Put ACPI device on missing physical node
authorShuhao Fu <sfual@cse.ust.hk>
Tue, 28 Apr 2026 08:12:38 +0000 (16:12 +0800)
committerTakashi Iwai <tiwai@suse.de>
Thu, 7 May 2026 14:31:25 +0000 (16:31 +0200)
commitfca7401fe37f7abc6e54147ea560f37279231137
treeb8a76f9dcec59781051c677f0e3534b272f91a96
parentaa2fbece1b07954ef26488c800d126a36a8ab93e
ALSA: hda: cs35l41: Put ACPI device on missing physical node

acpi_dev_get_first_match_dev() returns a refcounted ACPI device and
callers must balance it with acpi_dev_put().

cs35l41_hda_read_acpi() stores the returned ACPI device in
cs35l41->dacpi. That reference is normally released by the later
probe cleanup or the remove path, but the NULL-check on
physdev exits before either of those paths can run.

Drop the lookup reference before returning -ENODEV.

Fixes: c34b04cc6178 ("ALSA: hda: cs35l41: Fix NULL pointer dereference in cs35l41_hda_read_acpi()")
Signed-off-by: Shuhao Fu <sfual@cse.ust.hk>
Tested-by: Simon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20260428081238.GA1659932@chcpu16
sound/hda/codecs/side-codecs/cs35l41_hda.c