]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
pinctrl: pinctrl-pic32: Fix resource leak
authorEthan Tidmore <ethantidmore06@gmail.com>
Fri, 27 Feb 2026 21:56:23 +0000 (15:56 -0600)
committerLinus Walleij <linusw@kernel.org>
Mon, 2 Mar 2026 10:15:57 +0000 (11:15 +0100)
commitfe5560688f3ba98364c7de7b4f8dc240ffd1ff75
tree694abef78c717c268b354ea48d63eccfafc99abe
parenta92b75100826b1ea27e6b8a678e53970ad4736d7
pinctrl: pinctrl-pic32: Fix resource leak

Fix three possible resource leaks by using the devres version of
clk_prepare_enable(). Also, update error message accordingly.

Detected by Smatch:
drivers/pinctrl/pinctrl-pic32.c:2211 pic32_pinctrl_probe() warn:
'pctl->clk' from clk_prepare_enable() not released on lines: 2208.

drivers/pinctrl/pinctrl-pic32.c:2274 pic32_gpio_probe() warn:
'bank->clk' from clk_prepare_enable() not released on lines: 2264,2272.

Fixes: 2ba384e6c3810 ("pinctrl: pinctrl-pic32: Add PIC32 pin control driver")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
drivers/pinctrl/pinctrl-pic32.c