]> git.ipfire.org Git - thirdparty/linux.git/commit
ACPI: button: Fix ACPI GPE handler leak during removal
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 22 May 2026 14:49:44 +0000 (16:49 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 25 May 2026 07:52:33 +0000 (09:52 +0200)
commitfe80251152fed5b185f795ef2cd9f7fe9c3162e0
tree8d53a62bcfb087c5cae9f0d9b4b81b96c6f82dc6
parente7ae89a0c97ce2b68b0983cd01eda67cf373517d
ACPI: button: Fix ACPI GPE handler leak during removal

Commit a7e23ec17fee ("ACPI: button: Install notifier for system events
as well") changed the ACPI notify handler type for ACPI buttons to
ACPI_ALL_NOTIFY, but it forgot to update acpi_button_remove() to reflect
that change.  This leads to leaking the notify handler past driver
removal, which may cause a kernel crash to occur if ACPI notify on
the given device is triggered after removing the driver, and causes a
subsequent probe of the given device with the same driver to fail.

Address this by updating the acpi_remove_notify_handler() call in
acpi_button_remove() as appropriate.

Fixes: a7e23ec17fee ("ACPI: button: Install notifier for system events as well")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Cc: 6.15+ <stable@vger.kernel.org> # 6.15+
Link: https://patch.msgid.link/7954431.EvYhyI6sBW@rafael.j.wysocki
drivers/acpi/button.c