[gdb/testsuite] Improve gdb.python/remove-readline-finder.exp

I came across test-case gdb.python/remove-readline-finder.exp.

It checks that a "python import readline" command fails.

Extend the test-case with also checking that the readline module is not
present in the sys.modules dict.

While we're at it, modernize a regexp using multi_line.

Tested on x86_64-linux (using make-check-all.sh) and aarch64-linux.

diff --git a/gdb/testsuite/gdb.python/remove-readline-finder.exp b/gdb/testsuite/gdb.python/remove-readline-finder.exp
index 362e90e6b7c5d0c36faa8d5f9a91eb8453b05cae..325e9710e2814a0fdf10cdd08366f8deab837272 100644 (file)
--- a/gdb/testsuite/gdb.python/remove-readline-finder.exp
+++ b/gdb/testsuite/gdb.python/remove-readline-finder.exp
@@ -23,5 +23,21 @@ standard_testfile
 
 clean_restart
 
 
 clean_restart
 

+gdb_test_no_output "py import sys"
+
+# Check that readline is not imported.
+with_test_prefix initial {
+    gdb_test "py print (sys.modules.get('readline'))" \
+       "None"
+}
+
+# Try to import readline, and check that it fails.
+set re_msg "readline module disabled under GDB"

 gdb_test "py import readline" \
 gdb_test "py import readline" \

-  "Python Exception <class 'ImportError'>: readline module disabled under GDB\r\n.*"
+    [multi_line \
+       "Python Exception <class 'ImportError'>: $re_msg" \
+       "Error occurred in Python: $re_msg"]
+
+# Check that readline is still not imported.
+gdb_test "py print (sys.modules.get('readline'))" \
+    "None"