Only set key->engine if engine != NULL

diff --git a/lib/dns/openssleddsa_link.c b/lib/dns/openssleddsa_link.c
index f6d1fa3a140060945f24c550d09cd71f04d75f02..7e976a7756152572d5bff4f2378e86fc3303a880 100644 (file)
--- a/lib/dns/openssleddsa_link.c
+++ b/lib/dns/openssleddsa_link.c
@@ -527,7 +527,7 @@ openssleddsa_fromlabel(dst_key_t *key, const char *engine, const char *label,
                goto err;
        }
 
-       if (key->engine != NULL) {
+       if (engine != NULL) {
                key->engine = isc_mem_strdup(key->mctx, engine);
        }
        key->label = isc_mem_strdup(key->mctx, label);

diff --git a/lib/dns/opensslrsa_link.c b/lib/dns/opensslrsa_link.c
index 54ab04dcf7036154c4dfc69b69da6d05e6ecfb67..79cae64add56f14bf906e519c4dd51945563aef5 100644 (file)
--- a/lib/dns/opensslrsa_link.c
+++ b/lib/dns/opensslrsa_link.c
@@ -1051,7 +1051,7 @@ opensslrsa_fromlabel(dst_key_t *key, const char *engine, const char *label,
                DST_RET(ISC_R_RANGE);
        }
 
-       if (key->engine != NULL) {
+       if (engine != NULL) {
                key->engine = isc_mem_strdup(key->mctx, engine);
        }
        key->label = isc_mem_strdup(key->mctx, label);