]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
python: sd_utils: remove redundant brackets around simple assert statements
authorRob van der Linde <rob@catalyst.net.nz>
Thu, 15 Feb 2024 19:03:37 +0000 (08:03 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 1 Mar 2024 04:45:36 +0000 (04:45 +0000)
Ideally these should be exceptions not asserts

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
python/samba/sd_utils.py

index eace8cf0388722b128152d05213a815df7573878..57d9a1423c87bf1af338b58f3ba7452018973b60 100644 (file)
@@ -91,7 +91,7 @@ class SDUtils(object):
 
         def ace_from_sddl(ace_sddl):
             ace_sd = security.descriptor.from_sddl("D:" + ace_sddl, self.domain_sid)
-            assert (len(ace_sd.dacl.aces) == 1)
+            assert len(ace_sd.dacl.aces) == 1
             return ace_sd.dacl.aces[0]
 
         if sddl_attr is None:
@@ -131,7 +131,7 @@ class SDUtils(object):
         for ace in del_aces:
             if isinstance(ace, str):
                 ace = ace_from_sddl(ace)
-            assert (isinstance(ace, security.ace))
+            assert isinstance(ace, security.ace)
 
             if ace.flags & security.SEC_ACE_FLAG_INHERITED_ACE:
                 inherited_ignored.append(ace)
@@ -152,7 +152,7 @@ class SDUtils(object):
                 ace = ace["ace"]
             if isinstance(ace, str):
                 ace = ace_from_sddl(ace)
-            assert (isinstance(ace, security.ace))
+            assert isinstance(ace, security.ace)
 
             if ace.flags & security.SEC_ACE_FLAG_INHERITED_ACE:
                 inherited_ignored.append(ace)