]> git.ipfire.org Git - thirdparty/dracut-ng.git/commitdiff
ci(lint): remove broken parameter of sh-checker
authorJan Macku <jamacku@redhat.com>
Tue, 3 Oct 2023 08:30:06 +0000 (10:30 +0200)
committerNeal Gompa (ニール・ゴンパ) <ngompa13@gmail.com>
Tue, 2 Apr 2024 14:39:42 +0000 (10:39 -0400)
The `sh_checker_comment: true` requires special permissions (`pull-requests: write`).
This permission level could be achieved only on PR from the `dracut` repository. When PR is opened from the fork, it automatically drops to `read` only.

error message:
```
Commenting on the pull request
{
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/issues/comments#create-an-issue-comment"
}
```

.github/workflows/lint.yml

index f8f08faaddd27b44d6902703622bde60edc8a4a4..bba98cf6d163785e05bcf28bb6b29d9a48a0b78d 100644 (file)
@@ -16,11 +16,9 @@ jobs:
       - name: shfmt
         uses: luizm/action-sh-checker@v0.6.0
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SHFMT_OPTS: -s # arguments to shfmt.
         with:
           sh_checker_shellcheck_disable: false
-          sh_checker_comment: true
 
   differential-shellcheck:
     runs-on: ubuntu-latest