]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rxrpc: Fix key parsing memleak
authorDavid Howells <dhowells@redhat.com>
Wed, 8 Apr 2026 12:12:30 +0000 (13:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Apr 2026 08:46:46 +0000 (10:46 +0200)
commit b555912b9b21075e8298015f888ffe3ff60b1a97 upstream.

In rxrpc_preparse_xdr_yfs_rxgk(), the memory attached to token->rxgk can be
leaked in a few error paths after it's allocated.

Fix this by freeing it in the "reject_token:" case.

Fixes: 0ca100ff4df6 ("rxrpc: Add YFS RxGK (GSSAPI) security class")
Closes: https://sashiko.dev/#/patchset/20260319150150.4189381-1-dhowells%40redhat.com
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: Jeffrey Altman <jaltman@auristor.com>
cc: Simon Horman <horms@kernel.org>
cc: linux-afs@lists.infradead.org
cc: stable@kernel.org
Link: https://patch.msgid.link/20260408121252.2249051-3-dhowells@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/rxrpc/key.c

index bac2afdb3548c7a937af5af4d3263532d40532b5..c35acfaa9eabec53b189cff1527c1ba2d9436cfe 100644 (file)
@@ -274,6 +274,7 @@ nomem_token:
 nomem:
        return -ENOMEM;
 reject_token:
+       kfree(token->rxgk);
        kfree(token);
 reject:
        return -EKEYREJECTED;