]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: 6fire: Drop unnecessary NULL checks
authorTakashi Iwai <tiwai@suse.de>
Tue, 14 Apr 2026 13:22:14 +0000 (15:22 +0200)
committerTakashi Iwai <tiwai@suse.de>
Wed, 15 Apr 2026 12:27:28 +0000 (14:27 +0200)
The NULL checks of chip pointer in usb6fire_chip_abrt() and
usb6fire_card_free() are utterly useless, as it's guaranteed to be
non-NULL.  Drop them for increasing the readability.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20260414132218.411013-5-tiwai@suse.de
sound/usb/6fire/chip.c

index 556882bd90227c32c8a596fae70593afb60c3b44..2c5648966412a634f4e21ea67b7e77060d6f1109 100644 (file)
@@ -43,32 +43,28 @@ static DEFINE_MUTEX(register_mutex);
 
 static void usb6fire_chip_abort(struct sfire_chip *chip)
 {
-       if (chip) {
-               if (chip->pcm)
-                       usb6fire_pcm_abort(chip);
-               if (chip->midi)
-                       usb6fire_midi_abort(chip);
-               if (chip->comm)
-                       usb6fire_comm_abort(chip);
-               if (chip->control)
-                       usb6fire_control_abort(chip);
-       }
+       if (chip->pcm)
+               usb6fire_pcm_abort(chip);
+       if (chip->midi)
+               usb6fire_midi_abort(chip);
+       if (chip->comm)
+               usb6fire_comm_abort(chip);
+       if (chip->control)
+               usb6fire_control_abort(chip);
 }
 
 static void usb6fire_card_free(struct snd_card *card)
 {
        struct sfire_chip *chip = card->private_data;
 
-       if (chip) {
-               if (chip->pcm)
-                       usb6fire_pcm_destroy(chip);
-               if (chip->midi)
-                       usb6fire_midi_destroy(chip);
-               if (chip->comm)
-                       usb6fire_comm_destroy(chip);
-               if (chip->control)
-                       usb6fire_control_destroy(chip);
-       }
+       if (chip->pcm)
+               usb6fire_pcm_destroy(chip);
+       if (chip->midi)
+               usb6fire_midi_destroy(chip);
+       if (chip->comm)
+               usb6fire_comm_destroy(chip);
+       if (chip->control)
+               usb6fire_control_destroy(chip);
 }
 
 static int usb6fire_chip_probe(struct usb_interface *intf,