fbdev: uvesafb: fix potential memory leak in uvesafb_probe()

Due to an incorrect goto label, memory allocated for modedb and modelist
in uvesafb_vbe_init() is not freed in some error paths. Fix this by
updating the goto label.

Fixes: 8bdb3a2d7df4 ("uvesafb: the driver core")
Cc: stable@vger.kernel.org
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
index 88667fccc27b9766124c1b940f6f8d729fd27b4b..9d82326c744f220a36f93efb2d484accb61aa851 100644 (file)
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -1694,14 +1694,14 @@ static int uvesafb_probe(struct platform_device *dev)
        i = uvesafb_vbe_init_mode(info);
        if (i < 0) {
                err = -EINVAL;
-               goto out;
+               goto out_mode;
        } else {
                mode = &par->vbe_modes[i];
        }
 
        if (fb_alloc_cmap(&info->cmap, 256, 0) < 0) {
                err = -ENXIO;
-               goto out;
+               goto out_mode;
        }
 
        uvesafb_init_info(info, mode);