]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
don't use the ERR macro as GCC 7 only does a partial static analysis which generates...
authorMark Andrews <marka@isc.org>
Wed, 1 Nov 2017 08:11:48 +0000 (19:11 +1100)
committerMark Andrews <marka@isc.org>
Wed, 1 Nov 2017 08:11:48 +0000 (19:11 +1100)
lib/irs/getnameinfo.c

index c5f987dd7563e1612ec6778b26fc4ac63e0de081..6e26e278fd8a1115f73d0809fd3c9e2b4e7a6b4e 100644 (file)
@@ -319,8 +319,13 @@ getnameinfo(const struct sockaddr *sa, IRS_GETNAMEINFO_SOCKLEN_T salen,
                case DNS_R_NOVALIDKEY:
                case DNS_R_NOVALIDDS:
                case DNS_R_NOVALIDSIG:
-                       ERR(EAI_INSECUREDATA);
-                       /* NOTREACHED */
+                       /*
+                        * Don't use ERR as GCC 7 wants to raise a
+                        * warning with ERR about possible falling
+                        * through which is impossible.
+                        */
+                       result = EAI_INSECUREDATA;
+                       goto cleanup;
                default:
                        ERR(EAI_FAIL);
                }