]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[#3991] Fixed cppcheck virtualCallInConstructor
authorFrancis Dupont <fdupont@isc.org>
Tue, 12 May 2026 21:41:10 +0000 (23:41 +0200)
committerFrancis Dupont <fdupont@isc.org>
Wed, 27 May 2026 20:03:02 +0000 (22:03 +0200)
src/lib/dhcp/option6_pdexclude.cc
src/lib/dhcp/option6_status_code.cc
src/lib/dhcp/option_opaque_data_tuples.cc
src/lib/dhcp/option_vendor_class.cc

index b3ae2066aaa8dd1108a12e61a0d3432a0363e24f..c7e1e149eb886945a00c8fd1b0914e1c2c442041 100644 (file)
@@ -116,7 +116,7 @@ Option6PDExclude::Option6PDExclude(OptionBufferConstIter begin,
     : Option(V6, D6O_PD_EXCLUDE),
       excluded_prefix_length_(0),
       subnet_id_() {
-    unpack(begin, end);
+    Option6PDExclude::unpack(begin, end);
 }
 
 OptionPtr
index dcd92a88572f3f8f7fa1f34f224abb73d5e51bf3..310e16d3736e0652d659662a8e36f6487c24c96e 100644 (file)
@@ -39,7 +39,7 @@ Option6StatusCode::Option6StatusCode(OptionBufferConstIter begin,
       status_code_(STATUS_Success), status_message_() {
 
     // Parse data
-    unpack(begin, end);
+    Option6StatusCode::unpack(begin, end);
 }
 
 OptionPtr
@@ -149,7 +149,7 @@ Option4SlpServiceScope::Option4SlpServiceScope(OptionBufferConstIter begin,
       mandatory_flag_(false), scope_list_() {
 
     // Parse data
-    unpack(begin, end);
+    Option4SlpServiceScope::unpack(begin, end);
 }
 
 OptionPtr
index 3d945c2792f26568a7fa301125c3ce372d4cae96..aeb057c9b65472e3922f9c15d0fdd150b5749c19 100644 (file)
@@ -32,7 +32,7 @@ OptionOpaqueDataTuples::OptionOpaqueDataTuples(Option::Universe u,
     if (length_field_type_ == OpaqueDataTuple::LENGTH_EMPTY) {
         length_field_type_ = OptionDataTypeUtil::getTupleLenFieldType(u);
     }
-    unpack(begin, end);
+    OptionOpaqueDataTuples::unpack(begin, end);
 }
 
 OptionPtr
index dc44d768bd78df282e3e706dbcf8913ba39d5c8a..7428f4b1115d5cb6fb47b1f037dfb50a917677be 100644 (file)
@@ -28,7 +28,7 @@ OptionVendorClass::OptionVendorClass(Option::Universe u,
                                      OptionBufferConstIter begin,
                                      OptionBufferConstIter end)
     : Option(u, getOptionCode(u)) {
-    unpack(begin, end);
+    OptionVendorClass::unpack(begin, end);
 }
 
 OptionPtr